From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: time to move fs/bio.c to block/ ?
Date: Mon, 19 May 2014 17:39:42 +0100 [thread overview]
Message-ID: <20140519163942.GJ18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140519143416.GC568@infradead.org>
On Mon, May 19, 2014 at 07:34:16AM -0700, Christoph Hellwig wrote:
> On Mon, May 19, 2014 at 08:31:21AM -0600, Jens Axboe wrote:
> > > While you are at it, could you take bio-integrity.c with it? _That_
> > > has zero excuse being anywhere in fs/* - not even "filesystem code
> > > uses quite a few functions from that sucker" as with bio.c.
> > > FWIW, consider the move ACKed.
> >
> > Yeah, I did include that in the move.
>
> Other candidates to move to block/ might be ioprio.c and no-block.c
ACK on ioprio.c (BTW, looking at block... WTF is the story with that
pile of blk-* in there? IOW, why blk-exec.c is better than exec.c,
etc.?)
As for fs/no-block.c... IMO that's a bad idea - it makes sense only
if we take fs/block.c there as well, and that one wants fs/internal.h.
Why do we need that ->llseek = noop_llseek there, while we are at it?
Its ->open() always fails, so how is ->llseek() going to get looked at,
let alone called?
next prev parent reply other threads:[~2014-05-19 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:13 time to move fs/bio.c to block/ ? Christoph Hellwig
2014-05-19 14:14 ` Jens Axboe
2014-05-19 14:25 ` Al Viro
2014-05-19 14:31 ` Christoph Hellwig
2014-05-19 14:31 ` Jens Axboe
2014-05-19 14:34 ` Christoph Hellwig
2014-05-19 14:38 ` Jens Axboe
2014-05-19 16:39 ` Al Viro [this message]
2014-05-19 16:58 ` Christoph Hellwig
2014-05-19 17:05 ` Jens Axboe
2014-05-20 0:28 ` Ming Lei
2014-05-20 2:00 ` Jens Axboe
2014-05-19 14:28 ` Jianyu Zhan
2014-05-19 14:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519163942.GJ18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox