From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Matlack <matlackdavid@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Lior Dotan <liodot@gmail.com>,
linux-kernel@vger.kernel.org, charrer@alacritech.com
Subject: Re: [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code
Date: Tue, 20 May 2014 00:21:07 +0300 [thread overview]
Message-ID: <20140519212107.GC15585@mwanda> (raw)
In-Reply-To: <CANoiuGLzE=xbNjsFEsm9RAJrtEcGkd0rTy9t8ODzYEsGMUmNUQ@mail.gmail.com>
When you resend, please put in the changelog what the affect of this fix
is for the user. Even if it's something like "It doesn't affect the
user normally." that is useful information.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-19 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 4:00 [PATCH 0/2] staging: slicoss: cleanup checksum computation David Matlack
2014-05-18 4:00 ` [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code David Matlack
2014-05-18 4:12 ` Joe Perches
2014-05-18 4:51 ` David Matlack
2014-05-18 22:43 ` David Matlack
2014-05-19 9:16 ` Dan Carpenter
2014-05-19 20:49 ` David Matlack
2014-05-19 21:15 ` Dan Carpenter
2014-05-19 21:21 ` Dan Carpenter [this message]
2014-05-18 4:00 ` [PATCH 2/2] staging: slicoss: remove slic_reg_params struct David Matlack
2014-05-19 9:21 ` Dan Carpenter
2014-05-19 15:57 ` David Matlack
2014-05-19 19:52 ` Dan Carpenter
2014-05-19 20:54 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519212107.GC15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=matlackdavid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox