From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Romer, Benjamin M" <Benjamin.Romer@unisys.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
*S-Par-Maintainer <SParMaintainer@unisys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs
Date: Tue, 20 May 2014 10:09:21 +0900 [thread overview]
Message-ID: <20140520010921.GA27462@kroah.com> (raw)
In-Reply-To: <20140519195708.GY15585@mwanda>
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
> > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
> > > Also, why are these entries moving to debugfs at all? Why are they
> > > needed? Who will use them? Are tools relying on them to be there?
> >
> > The tuning entries are sometimes used to help adjust the behavior of our
> > IO service partitions for better performance.
>
> That sounds like it really belongs in sysfs instead of debugfs.
Exactly. debugfs files are for "debugging". Consider them files that
your driver can work properly if no one ever touches them.
"tuning" files imply something that has to be touched by users.
Ideally, you would never need such a thing as no one wants to have to
write things to files to make the kernel work better. But if you really
need it, they should be sysfs files, with the needed documentation.
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-20 1:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 16:38 [PATCH 0/7] staging: unisys: cleanup proc entries in uislib Benjamin Romer
2014-05-12 16:38 ` [PATCH 1/7] staging: unisys: remove testing proc interfaces from uislib Benjamin Romer
2014-05-12 16:38 ` [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs Benjamin Romer
2014-05-18 16:49 ` Greg KH
2014-05-19 14:42 ` Romer, Benjamin M
2014-05-19 19:57 ` Dan Carpenter
2014-05-20 1:09 ` Greg KH [this message]
2014-05-20 13:20 ` Romer, Benjamin M
2014-05-12 16:38 ` [PATCH 3/7] staging: unisys: move uislib/cycles_before_wait " Benjamin Romer
2014-05-12 16:38 ` [PATCH 4/7] staging: unisys: move uislib/smart_wakeup " Benjamin Romer
2014-05-12 16:38 ` [PATCH 5/7] staging: unisys: remove functions made redundant in uislib.c Benjamin Romer
2014-05-12 16:38 ` [PATCH 6/7] staging: unisys: move uislib/info proc entry to debugfs Benjamin Romer
2014-05-12 16:38 ` [PATCH 7/7] staging: unisys: remove remaining proc directory entries Benjamin Romer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520010921.GA27462@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Benjamin.Romer@unisys.com \
--cc=SParMaintainer@unisys.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox