From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Chen Yucong <slaoub@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Clear a useless global variable in mce.c
Date: Tue, 20 May 2014 12:02:52 +0200 [thread overview]
Message-ID: <20140520100252.GA16428@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F3280EA8A@ORSMSX114.amr.corp.intel.com>
On Mon, May 19, 2014 at 10:06:38PM +0000, Luck, Tony wrote:
> I doubt there is any hope for recovery if not all processors show up
> ... things have to be already very broken for the machine check to be
> blocked.
Good, so this whole babble about the potential of a timeout and whatever
is all beside the point.
What we want to do is if any of the cores are stuck - monarch or not -
we want to panic the hell out of this box and not do anything further.
So only the tolerant check would need adjusting.
> I'm OK with it going - but as I said before I'd like to see mce_callin
> printed (so I can tell if just one cpu showed up, just the cpus from
> one socket, or some other significant number).
I don't think you want to do this unconditionally, do you? Rather maybe
mce_timed_out dumps the order variable before the box panics :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-05-20 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 12:05 [PATCH] x86/mce: Clear a useless global variable in mce.c Chen Yucong
2014-05-19 17:59 ` Luck, Tony
2014-05-19 18:15 ` Borislav Petkov
2014-05-19 22:06 ` Luck, Tony
2014-05-20 10:02 ` Borislav Petkov [this message]
2014-05-20 17:46 ` Tony Luck
-- strict thread matches above, loose matches on Subject: below --
2014-05-17 8:45 Chen Yucong
2014-05-17 9:58 ` Borislav Petkov
2014-05-19 0:08 ` Chen Yucong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520100252.GA16428@pd.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox