Re: [PATCH v4 1/3] mfd: max8997: use regmap to access registers

[Lee Jones <lee.jones@linaro.org>]

> This patch modifies max8997 driver and each associated function driver,
> to use regmap instead of operating directly on i2c bus. It will allow to
> simplify IRQ handling using regmap-irq.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> [For extcon part]
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> [For leds part]
> Acked-by: Bryan Wu <cooloney@gmail.com>
> ---
>  drivers/extcon/extcon-max8997.c     |  31 ++++----
>  drivers/input/misc/max8997_haptic.c |  34 +++++----
>  drivers/leds/leds-max8997.c         |  13 ++--
>  drivers/mfd/Kconfig                 |   1 +
>  drivers/mfd/max8997-irq.c           |  64 +++++++---------
>  drivers/mfd/max8997.c               | 141 ++++++++++++++++-------------------

Looks to be doing the right things and the diff looks good.

For the MFD part:
  Acked-by: Lee Jones <lee.jones@linaro.org>

>  drivers/power/max8997_charger.c     |  33 +++++----
>  drivers/regulator/max8997.c         |  87 +++++++++++-----------
>  drivers/rtc/rtc-max8997.c           |  56 +++++++-------
>  include/linux/mfd/max8997-private.h |  17 ++---
>  10 files changed, 228 insertions(+), 249 deletions(-)

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog