From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676AbaETQTK (ORCPT ); Tue, 20 May 2014 12:19:10 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:54054 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbaETQTJ (ORCPT ); Tue, 20 May 2014 12:19:09 -0400 Date: Tue, 20 May 2014 17:19:02 +0100 From: Lee Jones To: Robert Baldyga Cc: sameo@linux.intel.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, m.szyprowski@samsung.com, k.kozlowski@samsung.com Subject: Re: [PATCH v4 1/3] mfd: max8997: use regmap to access registers Message-ID: <20140520161902.GD32025@lee--X1> References: <1398693358-28336-1-git-send-email-r.baldyga@samsung.com> <1398693358-28336-2-git-send-email-r.baldyga@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1398693358-28336-2-git-send-email-r.baldyga@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This patch modifies max8997 driver and each associated function driver, > to use regmap instead of operating directly on i2c bus. It will allow to > simplify IRQ handling using regmap-irq. > > Signed-off-by: Robert Baldyga > Reviewed-by: Krzysztof Kozlowski > > [For extcon part] > Acked-by: Chanwoo Choi > > [For leds part] > Acked-by: Bryan Wu > --- > drivers/extcon/extcon-max8997.c | 31 ++++---- > drivers/input/misc/max8997_haptic.c | 34 +++++---- > drivers/leds/leds-max8997.c | 13 ++-- > drivers/mfd/Kconfig | 1 + > drivers/mfd/max8997-irq.c | 64 +++++++--------- > drivers/mfd/max8997.c | 141 ++++++++++++++++------------------- Looks to be doing the right things and the diff looks good. For the MFD part: Acked-by: Lee Jones > drivers/power/max8997_charger.c | 33 +++++---- > drivers/regulator/max8997.c | 87 +++++++++++----------- > drivers/rtc/rtc-max8997.c | 56 +++++++------- > include/linux/mfd/max8997-private.h | 17 ++--- > 10 files changed, 228 insertions(+), 249 deletions(-) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog