From: Lee Jones <lee.jones@linaro.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Zhu, Lejun" <lejun.zhu@linux.intel.com>,
sameo@linux.intel.com, linux-kernel@vger.kernel.org,
bin.yang@intel.com
Subject: Re: [PATCH 0/4] mfd: Intel SoC Power Management IC
Date: Tue, 20 May 2014 17:50:28 +0100 [thread overview]
Message-ID: <20140520165027.GA32538@lee--X1> (raw)
In-Reply-To: <20140520160708.1382a6ab@alan.etchedpixels.co.uk>
> > I'm missing the build files patch. Can you ensure I was on the
> > distribution list please? Also, what's the reason for splitting the
> > files out instead of having one single driver?
>
> The same PMIC may be attached multiple ways, and multiple different PMIC
> types may be attached.
>
> So for example on the Baytrail/T platforms (ASUS T100 etc) you have
> crystal cove via i2c, but a vendor could use a different PMIC - and there
> will of course always be new PMIC devices coming along.
>
> Equally on a Z2760 or similar (eg the Lenovo tablet 2) you may well have
> the same PMIC attached to the system control unit. While there's nobody
> afaik trying to sync the Android trees for Clovertrail+ with upstream at
> this point I know there are external to Intel folks working on it for fun
> and we need to allow for that.
Fair enough, I'll bow to your knowledge. I was just looking at the
current driver and saw the lack of, for instance, intel_soc_pmic_spi.c
which would have warranted separate core/i2c/spi components. Also the
Kconfig configuration doesn't allow for individual compilation of each
of the source files, which drew me to the conclusion that these could
in fact be centralised.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-20 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 14:59 [PATCH 0/4] mfd: Intel SoC Power Management IC Zhu, Lejun
2014-05-14 14:59 ` [PATCH 1/4] mfd: intel_soc_pmic: Core driver Zhu, Lejun
2014-05-20 14:58 ` Lee Jones
2014-05-20 23:40 ` Zhu, Lejun
2014-05-14 14:59 ` [PATCH 2/4] mfd: intel_soc_pmic: I2C interface Zhu, Lejun
2014-05-14 14:59 ` [PATCH 3/4] mfd: intel_soc_pmic: Crystal Cove support Zhu, Lejun
2014-05-14 14:59 ` [PATCH 4/4] mfd: intel_soc_pmic: Build files Zhu, Lejun
2014-05-20 23:39 ` [Resend][PATCH " Zhu, Lejun
2014-05-20 14:55 ` [PATCH 0/4] mfd: Intel SoC Power Management IC Lee Jones
2014-05-20 15:07 ` One Thousand Gnomes
2014-05-20 16:50 ` Lee Jones [this message]
2014-05-20 23:37 ` Zhu, Lejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520165027.GA32538@lee--X1 \
--to=lee.jones@linaro.org \
--cc=bin.yang@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=lejun.zhu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox