[PATCH 0/5] treewide: Convert logging message misuses of /n to \n

[PATCH 0/5] treewide: Convert logging message misuses of /n to \n

[Joe Perches]

Joe Perches (5):
  qlge: Convert /n to \n
  iwlegacy: Convert /n to \n
  staging: rtl<foo>: Convert /n to \n
  appledisplay: Convert /n to \n
  sound: tlv320aic31xx: Convert /n to \n

 drivers/net/ethernet/qlogic/qlge/qlge_main.c  | 2 +-
 drivers/net/wireless/iwlegacy/3945.c          | 2 +-
 drivers/net/wireless/iwlegacy/4965-mac.c      | 2 +-
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
 drivers/staging/rtl8188eu/os_dep/usb_intf.c   | 2 +-
 drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
 drivers/staging/rtl8723au/os_dep/usb_intf.c   | 2 +-
 drivers/usb/misc/appledisplay.c               | 2 +-
 sound/soc/codecs/tlv320aic31xx.c              | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

-- 
1.8.1.2.459.gbcd45b4.dirty

[PATCH 1/5] qlge: Convert /n to \n

[Joe Perches]

Use a newline character appropriately.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 0a1d76a..6e36fe1 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -3595,7 +3595,7 @@ static int ql_request_irq(struct ql_adapter *qdev)
 	}
 	return status;
 err_irq:
-	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!/n");
+	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!\n");
 	ql_free_irq(qdev);
 	return status;
 }
-- 
1.8.1.2.459.gbcd45b4.dirty

Re: [PATCH 1/5] qlge: Convert /n to \n

[Jitendra Kalsaria]

On 4/24/14 6:50 PM, "Joe Perches" <joe@perches.com> wrote:

>Use a newline character appropriately.
>
>Signed-off-by: Joe Perches <joe@perches.com>
>---
> drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>index 0a1d76a..6e36fe1 100644
>--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
>@@ -3595,7 +3595,7 @@ static int ql_request_irq(struct ql_adapter *qdev)
> 	}
> 	return status;
> err_irq:
>-	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!/n");
>+	netif_err(qdev, ifup, qdev->ndev, "Failed to get the interrupts!!!\n");
> 	ql_free_irq(qdev);
> 	return status;
> }
>-- 
>1.8.1.2.459.gbcd45b4.dirty
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>

Re: [PATCH 1/5] qlge: Convert /n to \n

[David Miller]

From: Joe Perches <joe@perches.com>
Date: Thu, 24 Apr 2014 18:50:59 -0700

> Use a newline character appropriately.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks.

[PATCH 2/5] iwlegacy: Convert /n to \n

[Joe Perches]

Use a newline character appropriately.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/wireless/iwlegacy/3945.c     | 2 +-
 drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/iwlegacy/3945.c b/drivers/net/wireless/iwlegacy/3945.c
index d37a6fd..b598e28 100644
--- a/drivers/net/wireless/iwlegacy/3945.c
+++ b/drivers/net/wireless/iwlegacy/3945.c
@@ -573,7 +573,7 @@ il3945_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 		rx_status.flag |= RX_FLAG_SHORTPRE;
 
 	if ((unlikely(rx_stats->phy_count > 20))) {
-		D_DROP("dsp size out of range [0,20]: %d/n",
+		D_DROP("dsp size out of range [0,20]: %d\n",
 		       rx_stats->phy_count);
 		return;
 	}
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 888ad5c..c159c05 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -670,7 +670,7 @@ il4965_hdl_rx(struct il_priv *il, struct il_rx_buf *rxb)
 	}
 
 	if ((unlikely(phy_res->cfg_phy_cnt > 20))) {
-		D_DROP("dsp size out of range [0,20]: %d/n",
+		D_DROP("dsp size out of range [0,20]: %d\n",
 		       phy_res->cfg_phy_cnt);
 		return;
 	}
-- 
1.8.1.2.459.gbcd45b4.dirty

[PATCH 3/5] staging: rtl<foo>: Convert /n to \n

[Joe Perches]

Use a newline character appropriately.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
 drivers/staging/rtl8188eu/os_dep/usb_intf.c   | 2 +-
 drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
 drivers/staging/rtl8723au/os_dep/usb_intf.c   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index 1fa5370..e94c689 100644
--- a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
@@ -559,7 +559,7 @@ static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs)
 			rtw_read_port(adapt, precvpriv->ff_hwaddr, 0, (unsigned char *)precvbuf);
 			break;
 		case -EINPROGRESS:
-			DBG_88E("ERROR: URB IS IN PROGRESS!/n");
+			DBG_88E("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 49a4ce4..b899191 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -128,7 +128,7 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 
 	dvobj->usb_alloc_vendor_req_buf = rtw_zmalloc(MAX_USB_IO_CTL_SIZE);
 	if (dvobj->usb_alloc_vendor_req_buf == NULL) {
-		DBG_88E("alloc usb_vendor_req_buf failed... /n");
+		DBG_88E("alloc usb_vendor_req_buf failed...\n");
 		rst = _FAIL;
 		goto exit;
 	}
diff --git a/drivers/staging/rtl8723au/hal/usb_ops_linux.c b/drivers/staging/rtl8723au/hal/usb_ops_linux.c
index 0311cdf..f5a6e61 100644
--- a/drivers/staging/rtl8723au/hal/usb_ops_linux.c
+++ b/drivers/staging/rtl8723au/hal/usb_ops_linux.c
@@ -415,7 +415,7 @@ urb_submit:
 		case -EPROTO:
 			break;
 		case -EINPROGRESS:
-			DBG_8723A("ERROR: URB IS IN PROGRESS!/n");
+			DBG_8723A("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;
@@ -711,7 +711,7 @@ static void usb_read_port_complete(struct urb *purb, struct pt_regs *regs)
 				      0, precvbuf);
 			break;
 		case -EINPROGRESS:
-			DBG_8723A("ERROR: URB IS IN PROGRESS!/n");
+			DBG_8723A("ERROR: URB IS IN PROGRESS!\n");
 			break;
 		default:
 			break;
diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c
index 31ab346..287439a 100644
--- a/drivers/staging/rtl8723au/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8723au/os_dep/usb_intf.c
@@ -109,7 +109,7 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
 	dvobj->usb_alloc_vendor_req_buf = kzalloc(MAX_USB_IO_CTL_SIZE,
 						  GFP_KERNEL);
 	if (dvobj->usb_alloc_vendor_req_buf == NULL) {
-		DBG_8723A("alloc usb_vendor_req_buf failed... /n");
+		DBG_8723A("alloc usb_vendor_req_buf failed...\n");
 		rst = _FAIL;
 		goto exit;
 	}
-- 
1.8.1.2.459.gbcd45b4.dirty

[PATCH 4/5] appledisplay: Convert /n to \n

[Joe Perches]

Use a newline character appropriately.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/usb/misc/appledisplay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c
index ba6a5d6..f37c78d 100644
--- a/drivers/usb/misc/appledisplay.c
+++ b/drivers/usb/misc/appledisplay.c
@@ -110,7 +110,7 @@ static void appledisplay_complete(struct urb *urb)
 			__func__, status);
 		return;
 	default:
-		dev_dbg(dev, "%s - nonzero urb status received: %d/n",
+		dev_dbg(dev, "%s - nonzero urb status received: %d\n",
 			__func__, status);
 		goto exit;
 	}
-- 
1.8.1.2.459.gbcd45b4.dirty

Re: [PATCH 4/5] appledisplay: Convert /n to \n

[Joe Perches]

On Thu, 2014-04-24 at 18:51 -0700, Joe Perches wrote:
> Use a newline character appropriately.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---

Greg?  Ping?

You inadvertently added this "/n" use in
commit 0a3fd536e685e0ceb646de1a43821bd11c0be75c
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Tue May 1 21:33:54 2012 -0700

    USB: appledisplay.c: remove dbg() usage
    
    dbg() was a very old USB-specific macro that should no longer
    be used. This patch removes it from being used in the driver
    and uses dev_dbg() instead.

>  drivers/usb/misc/appledisplay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c
> index ba6a5d6..f37c78d 100644
> --- a/drivers/usb/misc/appledisplay.c
> +++ b/drivers/usb/misc/appledisplay.c
> @@ -110,7 +110,7 @@ static void appledisplay_complete(struct urb *urb)
>  			__func__, status);
>  		return;
>  	default:
> -		dev_dbg(dev, "%s - nonzero urb status received: %d/n",
> +		dev_dbg(dev, "%s - nonzero urb status received: %d\n",
>  			__func__, status);
>  		goto exit;
>  	}

Re: [PATCH 4/5] appledisplay: Convert /n to \n

[Greg Kroah-Hartman]

On Tue, May 20, 2014 at 12:26:53PM -0700, Joe Perches wrote:
> On Thu, 2014-04-24 at 18:51 -0700, Joe Perches wrote:
> > Use a newline character appropriately.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> 
> Greg?  Ping?
> 
> You inadvertently added this "/n" use in
> commit 0a3fd536e685e0ceb646de1a43821bd11c0be75c
> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Tue May 1 21:33:54 2012 -0700
> 
>     USB: appledisplay.c: remove dbg() usage
>     
>     dbg() was a very old USB-specific macro that should no longer
>     be used. This patch removes it from being used in the driver
>     and uses dev_dbg() instead.

Sorry, it's in my queue, just stalled due to traveling.  It's not lost,
don't worry.

greg k-h

[PATCH 5/5] sound: tlv320aic31xx: Convert /n to \n

[Joe Perches]

Use a newline character appropriately.

Signed-off-by: Joe Perches <joe@perches.com>
---
 sound/soc/codecs/tlv320aic31xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index b93d500..2341910 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -377,7 +377,7 @@ static int aic31xx_dapm_power_event(struct snd_soc_dapm_widget *w,
 		reg = AIC31XX_ADCFLAG;
 		break;
 	default:
-		dev_err(w->codec->dev, "Unknown widget '%s' calling %s/n",
+		dev_err(w->codec->dev, "Unknown widget '%s' calling %s\n",
 			w->name, __func__);
 		return -EINVAL;
 	}
-- 
1.8.1.2.459.gbcd45b4.dirty

Re: [PATCH 5/5] sound: tlv320aic31xx: Convert /n to \n

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

On Thu, Apr 24, 2014 at 06:51:03PM -0700, Joe Perches wrote:
> Use a newline character appropriately.

Applied.  As ever please do try to use subject lines appropriate to the
subsystem.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]