From: Matt Fleming <matt@console-pimps.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [GIT PULL] EFI changes for v3.16
Date: Tue, 20 May 2014 21:27:55 +0100 [thread overview]
Message-ID: <20140520202755.GI4798@console-pimps.org> (raw)
In-Reply-To: <537A8A03.8060604@zytor.com>
On Mon, 19 May, at 03:47:31PM, H. Peter Anvin wrote:
>
> How on earth does this solve anything? The only thing we add here is a
> WARN_ON_ONCE()... but the above text already tells us we have a problem.
>
> It seems, rather, that we need to figure out how to deal with a pstore
> in this case. There are a few possibilities:
>
> 1. We could keep an XSAVE buffer area around for this particular use.
> I am *assuming* we don't let more than one CPU into EFI, because I
> cannot for my life imagine that this is safe in typical CPUs.
Correct. This is actually prohibited by the spec, so we have a lock to
enforce it.
> 2. Drop the pstore on the floor if !irq_fpu_usable().
>
> 3. Allow the pstore, then die (on the assumption that we're dead
> anyway.)
Personally, I'd prefer 2, but I'm open to suggestions.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-05-20 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 13:04 [GIT PULL] EFI changes for v3.16 Matt Fleming
2014-05-19 10:51 ` Matt Fleming
2014-05-19 22:47 ` H. Peter Anvin
2014-05-19 23:10 ` Borislav Petkov
2014-05-20 0:17 ` H. Peter Anvin
2014-05-20 11:00 ` Borislav Petkov
2014-05-20 20:27 ` Matt Fleming [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-19 10:06 Matt Fleming
2014-04-19 22:42 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520202755.GI4798@console-pimps.org \
--to=matt@console-pimps.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox