[PATCH] staging: ozwpan: ozproto.c: Fix for possible null pointer dereference

[PATCH] staging: ozwpan: ozproto.c: Fix for possible null pointer dereference

[Rickard Strandqvist]

There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/ozwpan/ozproto.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index f09acd0..158e0d2 100644
--- a/drivers/staging/ozwpan/ozproto.c
+++ b/drivers/staging/ozwpan/ozproto.c
@@ -765,7 +765,10 @@ static char *oz_get_next_device_name(char *s, char *dname, int max_size)
 int oz_protocol_init(char *devs)
 {
 	skb_queue_head_init(&g_rx_queue);
-	if (devs && (devs[0] == '*')) {
+	if (!devs) {
+		return 0;
+	}
+	if (devs[0] == '*') {
 		oz_binding_add(NULL);
 	} else {
 		char d[32];
-- 
1.7.10.4

Re: [PATCH] staging: ozwpan: ozproto.c: Fix for possible null pointer dereference

[Dan Carpenter]

On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
> 
> Was largely found by using a static code analysis program called cppcheck.
> 

This is the empty string by default, or a module parameter.  I have
looked at param_set_charp() and I don't think a string module parameter
can be a NULL pointer.

regards,
dan carpenter

Re: [PATCH] staging: ozwpan: ozproto.c: Fix for possible null pointer dereference

[DaeSeok Youn]

I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114

Regards,
Daeseok Youn.

2014-05-21 6:48 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
>> Was largely found by using a static code analysis program called cppcheck.
>>
>
> This is the empty string by default, or a module parameter.  I have
> looked at param_set_charp() and I don't think a string module parameter
> can be a NULL pointer.
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/