From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751018AbaETVtE (ORCPT ); Tue, 20 May 2014 17:49:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44487 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbaETVtB (ORCPT ); Tue, 20 May 2014 17:49:01 -0400 Date: Wed, 21 May 2014 00:48:46 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Rupesh Gujare , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ozwpan: ozproto.c: Fix for possible null pointer dereference Message-ID: <20140520214846.GO15585@mwanda> References: <1400621339-7514-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400621339-7514-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > This is the empty string by default, or a module parameter. I have looked at param_set_charp() and I don't think a string module parameter can be a NULL pointer. regards, dan carpenter