From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Xenia Ragiadakou <burzalodowa@gmail.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Ana Rey <anarey@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: r8192U_core.c: Fix for possible null pointer dereference
Date: Wed, 21 May 2014 00:54:31 +0300 [thread overview]
Message-ID: <20140520215431.GG17724@mwanda> (raw)
In-Reply-To: <1400621573-7672-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Tue, May 20, 2014 at 11:32:53PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
Could you mention in the change log which pointer you are worried about?
I think you are concerned about "priv" here. "priv" comes from
container_of() and checking the return value of container_of() doesn't
make sense. It does some pointer math so even if "work" is NULL the
"priv" pointer would be non-zero.
Just remove the check.
regards,
dan carpenter
prev parent reply other threads:[~2014-05-20 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 21:32 [PATCH] staging: rtl8192u: r8192U_core.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-20 21:54 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520215431.GG17724@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anarey@gmail.com \
--cc=burzalodowa@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox