From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Manu Gupta <manugupt1@gmail.com>
Subject: Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Fix for possible null pointer dereference
Date: Wed, 21 May 2014 00:57:47 +0300 [thread overview]
Message-ID: <20140520215747.GP15585@mwanda> (raw)
In-Reply-To: <1400621477-7603-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Tue, May 20, 2014 at 11:31:16PM +0200, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
"padapter" can't be NULL. Just remove the check.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-20 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 21:31 [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Fix for possible null pointer dereference Rickard Strandqvist
2014-05-20 21:57 ` Dan Carpenter [this message]
2014-05-20 23:26 ` Larry Finger
2014-05-20 23:57 ` josh
2014-05-21 7:24 ` Dan Carpenter
2014-05-21 21:51 ` Rickard Strandqvist
2014-05-21 22:12 ` Dan Carpenter
2014-05-20 23:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520215747.GP15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manugupt1@gmail.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox