From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750942AbaETWEQ (ORCPT ); Tue, 20 May 2014 18:04:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51207 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721AbaETWEP (ORCPT ); Tue, 20 May 2014 18:04:15 -0400 Date: Wed, 21 May 2014 01:03:56 +0300 From: Dan Carpenter To: Rickard Strandqvist Cc: Larry Finger , Florian Schilhabel , devel@driverdev.osuosl.org, Greg Kroah-Hartman , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8712: usb_intf.c: Fix for possible null pointer dereference Message-ID: <20140520220356.GQ15585@mwanda> References: <1400621665-7746-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400621665-7746-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 20, 2014 at 11:34:25PM +0200, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist This is a real bug. :) Reviewed-by: Dan Carpenter Btw, I have named this kind of bug a "one err bug" because there is one "err:" label which handles all the error handling. It is a very common kind of bug. regards, dan carpenter