From: Bjorn Helgaas <bhelgaas@google.com>
To: "gioh.kim" <gioh.kim@lge.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
gunho.lee@lge.com
Subject: Re: [PATCH] Documentation/DMA-API-HOWTO.txt: update API descriptions
Date: Tue, 20 May 2014 17:19:40 -0600 [thread overview]
Message-ID: <20140520231940.GA24638@google.com> (raw)
In-Reply-To: <1399895153-29451-1-git-send-email-gioh.kim@lge.com>
On Mon, May 12, 2014 at 08:45:52PM +0900, gioh.kim wrote:
> From: "gioh.kim" <gioh.kim@lge.com>
>
> update descriptions for dma_pool_create and dma_pool_alloc
>
> Signed-off-by: Gioh Kim <gioh.kim@lge.com>
I applied this to my "dma-api" branch for v3.16, thanks!
(I fixed up the From: line as you did for the other patch.)
> ---
> Documentation/DMA-API-HOWTO.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt
> index 5e98303..e4251a3 100644
> --- a/Documentation/DMA-API-HOWTO.txt
> +++ b/Documentation/DMA-API-HOWTO.txt
> @@ -373,13 +373,13 @@ Create a dma_pool like this:
>
> struct dma_pool *pool;
>
> - pool = dma_pool_create(name, dev, size, align, alloc);
> + pool = dma_pool_create(name, dev, size, align, boundary);
>
> The "name" is for diagnostics (like a kmem_cache name); dev and size
> are as above. The device's hardware alignment requirement for this
> type of data is "align" (which is expressed in bytes, and must be a
> power of two). If your device has no boundary crossing restrictions,
> -pass 0 for alloc; passing 4096 says memory allocated from this pool
> +pass 0 for boundary; passing 4096 says memory allocated from this pool
> must not cross 4KByte boundaries (but at that time it may be better to
> go for dma_alloc_coherent directly instead).
>
> @@ -387,8 +387,8 @@ Allocate memory from a dma pool like this:
>
> cpu_addr = dma_pool_alloc(pool, flags, &dma_handle);
>
> -flags are SLAB_KERNEL if blocking is permitted (not in_interrupt nor
> -holding SMP locks), SLAB_ATOMIC otherwise. Like dma_alloc_coherent,
> +flags are GFP_KERNEL if blocking is permitted (not in_interrupt nor
> +holding SMP locks), GFP_ATOMIC otherwise. Like dma_alloc_coherent,
> this returns two values, cpu_addr and dma_handle.
>
> Free memory that was allocated from a dma_pool like this:
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-05-20 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 11:45 [PATCH] Documentation/DMA-API-HOWTO.txt: update API descriptions gioh.kim
2014-05-20 23:19 ` Bjorn Helgaas [this message]
2014-05-20 23:25 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520231940.GA24638@google.com \
--to=bhelgaas@google.com \
--cc=gioh.kim@lge.com \
--cc=gunho.lee@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox