From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbaETXTq (ORCPT ); Tue, 20 May 2014 19:19:46 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:33538 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbaETXTo (ORCPT ); Tue, 20 May 2014 19:19:44 -0400 Date: Tue, 20 May 2014 17:19:40 -0600 From: Bjorn Helgaas To: "gioh.kim" Cc: Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, gunho.lee@lge.com Subject: Re: [PATCH] Documentation/DMA-API-HOWTO.txt: update API descriptions Message-ID: <20140520231940.GA24638@google.com> References: <1399895153-29451-1-git-send-email-gioh.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399895153-29451-1-git-send-email-gioh.kim@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2014 at 08:45:52PM +0900, gioh.kim wrote: > From: "gioh.kim" > > update descriptions for dma_pool_create and dma_pool_alloc > > Signed-off-by: Gioh Kim I applied this to my "dma-api" branch for v3.16, thanks! (I fixed up the From: line as you did for the other patch.) > --- > Documentation/DMA-API-HOWTO.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt > index 5e98303..e4251a3 100644 > --- a/Documentation/DMA-API-HOWTO.txt > +++ b/Documentation/DMA-API-HOWTO.txt > @@ -373,13 +373,13 @@ Create a dma_pool like this: > > struct dma_pool *pool; > > - pool = dma_pool_create(name, dev, size, align, alloc); > + pool = dma_pool_create(name, dev, size, align, boundary); > > The "name" is for diagnostics (like a kmem_cache name); dev and size > are as above. The device's hardware alignment requirement for this > type of data is "align" (which is expressed in bytes, and must be a > power of two). If your device has no boundary crossing restrictions, > -pass 0 for alloc; passing 4096 says memory allocated from this pool > +pass 0 for boundary; passing 4096 says memory allocated from this pool > must not cross 4KByte boundaries (but at that time it may be better to > go for dma_alloc_coherent directly instead). > > @@ -387,8 +387,8 @@ Allocate memory from a dma pool like this: > > cpu_addr = dma_pool_alloc(pool, flags, &dma_handle); > > -flags are SLAB_KERNEL if blocking is permitted (not in_interrupt nor > -holding SMP locks), SLAB_ATOMIC otherwise. Like dma_alloc_coherent, > +flags are GFP_KERNEL if blocking is permitted (not in_interrupt nor > +holding SMP locks), GFP_ATOMIC otherwise. Like dma_alloc_coherent, > this returns two values, cpu_addr and dma_handle. > > Free memory that was allocated from a dma_pool like this: > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/