From: Lee Jones <lee.jones@linaro.org>
To: Matt Porter <mporter@linaro.org>
Cc: Devicetree List <devicetree@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Tim Kryger <tim.kryger@linaro.org>,
Markus Mayer <markus.mayer@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators
Date: Wed, 21 May 2014 14:30:38 +0100 [thread overview]
Message-ID: <20140521133038.GJ6679@lee--X1> (raw)
In-Reply-To: <20140521120257.GV32082@beef>
> > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi
> > > index dfadaaa..066adfb 100644
> > > --- a/arch/arm/boot/dts/bcm59056.dtsi
> > > +++ b/arch/arm/boot/dts/bcm59056.dtsi
> > > @@ -70,5 +70,26 @@
> > >
> > > vsr_reg: vsr {
> > > };
> > > +
> > > + gpldo1_reg: gpldo1 {
> > > + };
> >
> > What do these empty nodes do in any case?
>
> They instantiate regulators. The bcm590xx binding specifies the
> allowable subnode names permitted here. This replaces the old method
> of specifying an index or the deprecated regulator-compatible property.
> The board-specific dts includes this dtsi and applies any board
> constraints to a subset of regulators that need them. Unused regulators
> are all disabled which is what we want.
>
> > Don't you at least need a status property in there or something?
>
> Not necessary for these subnodes.
Very well, thanks for the clarification.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-21 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:21 [PATCH v2 0/4] Support additional regulators on BCM590xx Matt Porter
2014-04-23 23:21 ` [PATCH v2 1/4] mfd: bcm590xx: update binding with additional BCM59056 regulators Matt Porter
2014-04-23 23:21 ` [PATCH v2 2/4] mfd: bcm590xx: add support for secondary I2C slave address Matt Porter
2014-04-28 11:56 ` Lee Jones
2014-04-28 14:09 ` Matt Porter
2014-05-20 16:11 ` Lee Jones
2014-05-20 19:00 ` Mark Brown
2014-05-20 20:29 ` Matt Porter
2014-05-20 21:44 ` Mark Brown
2014-05-20 21:57 ` Matt Porter
2014-05-20 22:17 ` Mark Brown
2014-05-21 9:26 ` Lee Jones
2014-04-23 23:21 ` [PATCH v2 3/4] regulator: bcm590xx: add support for regulators on secondary I2C slave Matt Porter
2014-04-23 23:21 ` [PATCH v2 4/4] ARM: dts: bcm590xx: add support for GPLDO and VBUS regulators Matt Porter
2014-05-21 9:29 ` Lee Jones
2014-05-21 12:02 ` Matt Porter
2014-05-21 13:30 ` Lee Jones [this message]
2014-05-23 12:09 ` Matt Porter
2014-05-21 9:48 ` [GIT PULL] mfd: Second IB for Mark (regulator) Lee Jones
2014-05-21 23:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521133038.GJ6679@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=mporter@linaro.org \
--cc=sameo@linux.intel.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox