From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754011AbaEVITy (ORCPT ); Thu, 22 May 2014 04:19:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:45375 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbaEVITw (ORCPT ); Thu, 22 May 2014 04:19:52 -0400 Date: Thu, 22 May 2014 11:19:11 +0300 From: Dan Carpenter To: Luis Henriques Cc: Willy Tarreau , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ben Myers Subject: Re: [ 137/143] xfs: underflow bug in xfs_attrlist_by_handle() Message-ID: <20140522081911.GR17724@mwanda> References: <20140512003206.396224510@1wt.eu> <20140513110812.GA4006@hercules> <20140514095020.GC16836@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140514095020.GC16836@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 14, 2014 at 12:50:20PM +0300, Dan Carpenter wrote: > On Tue, May 13, 2014 at 12:08:12PM +0100, Luis Henriques wrote: > > > diff --git a/fs/xfs/linux-2.6/xfs_ioctl32.c b/fs/xfs/linux-2.6/xfs_ioctl32.c > > > index bad485a..782d03d 100644 > > > --- a/fs/xfs/linux-2.6/xfs_ioctl32.c > > > +++ b/fs/xfs/linux-2.6/xfs_ioctl32.c > > > @@ -361,8 +361,8 @@ xfs_compat_attrlist_by_handle( > > > if (copy_from_user(&al_hreq, arg, > > > sizeof(compat_xfs_fsop_attrlist_handlereq_t))) > > > return -XFS_ERROR(EFAULT); > > > - if (al_hreq.buflen > XATTR_LIST_MAX) > > > - return -XFS_ERROR(EINVAL); > > > > Am I missing something or was the above return statement deleted by > > mistake? > > > > Cheers, > > -- > > Luís > > Good eye. I have created a Smatch check to look for these bugs. > Oh. It turns out checkpatch.pl catches this bug as well. regards, dan carpenter