From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Zhu, Lejun" <lejun.zhu@linux.intel.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
mathias.nyman@linux.intel.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, jacob.jun.pan@linux.intel.com,
bin.yang@intel.com
Subject: Re: [PATCH v3] gpio: Add support for Intel SoC PMIC (Crystal Cove)
Date: Thu, 22 May 2014 14:15:54 +0300 [thread overview]
Message-ID: <20140522111554.GG1651@lahna.fi.intel.com> (raw)
In-Reply-To: <1400734743-3154-1-git-send-email-lejun.zhu@linux.intel.com>
On Thu, May 22, 2014 at 12:59:03PM +0800, Zhu, Lejun wrote:
> +static int crystalcove_gpio_probe(struct platform_device *pdev)
> +{
> + int irq = platform_get_irq(pdev, 0);
> + struct crystalcove_gpio *cg;
> + int retval;
> + struct device *dev = pdev->dev.parent;
> +
> + cg = devm_kzalloc(&pdev->dev, sizeof(*cg), GFP_KERNEL);
> + if (!cg) {
A minor comment here:
return -ENOMEM;
> + retval = -ENOMEM;
> + goto out;
> + }
Other than that this looks good to me,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I suppose this is dependent on the MFD driver right? If so, this should
probably be merged along with that patch.
next prev parent reply other threads:[~2014-05-22 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 4:59 [PATCH v3] gpio: Add support for Intel SoC PMIC (Crystal Cove) Zhu, Lejun
2014-05-22 11:15 ` Mika Westerberg [this message]
2014-05-23 1:26 ` Zhu, Lejun
2014-05-29 13:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522111554.GG1651@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bin.yang@intel.com \
--cc=gnurou@gmail.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lejun.zhu@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox