From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Christophe Kerello <christophe.kerello@st.com>,
computersforpeace@gmail.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 09/10] mtd: st_spi_fsm: Provide mask to obtain correct boot device pins
Date: Thu, 22 May 2014 12:52:16 +0100 [thread overview]
Message-ID: <20140522115216.GV6679@lee--X1> (raw)
In-Reply-To: <4231397.Nn7Rm5jh2O@wuerfel>
> On Thursday 22 May 2014 12:24:07 Lee Jones wrote:
> > + /* Mask to apply on boot_device_reg */
> > + ret = of_property_read_u32(np, "st,boot-device-msk", &boot_device_msk);
> > + if (ret)
> > + goto boot_device_fail;
> > +
> >
>
> The binding defines this property as "optional", but the driver fails
> here if it's not provided. I suggest you add a default value here so you
> can deal with existing dts. The default should be documented in
> the binding as well.
The property is optional. It doesn't fail completely, merely skips the
boot device check and falls back to using SPI. I can update the
documentation to this effect though, no problem.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-05-22 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 11:23 [PATCH v2 00/10] mtd: st_spi_fsm: Align with ST's internal development Lee Jones
2014-05-22 11:23 ` [PATCH 01/10] mtd: st_spi_fsm: Extend fsm_clear_fifo to handle unwanted bytes Lee Jones
2014-05-22 11:24 ` [PATCH 02/10] mtd: st_spi_fsm: Obtain and use EMI clock if provided Lee Jones
2014-05-22 11:24 ` [PATCH 03/10] mtd: st_spi_fsm: Add support for Micron N25Q512A Lee Jones
2014-05-22 11:24 ` [PATCH 04/10] mtd: st_spi_fsm: Add support for N25Q512 and N25Q00A devices Lee Jones
2014-05-22 11:24 ` [PATCH 05/10] mtd: st_spi_fsm: Update the JEDEC probe to handle extended READIDs Lee Jones
2014-05-22 11:24 ` [PATCH 06/10] mtd: st_spi_fsm: Update Spansion device entries Lee Jones
2014-05-22 11:24 ` [PATCH 07/10] mtd: st_spi_fsm: Improve busy wait handling Lee Jones
2014-05-22 11:24 ` [PATCH 08/10] mtd: st_spi_fsm: Provide documentation for boot device mask property Lee Jones
2014-05-22 11:59 ` [PATCH v2 " Lee Jones
2014-05-22 11:24 ` [PATCH 09/10] mtd: st_spi_fsm: Provide mask to obtain correct boot device pins Lee Jones
2014-05-22 11:47 ` Arnd Bergmann
2014-05-22 11:52 ` Lee Jones [this message]
2014-05-22 11:53 ` Arnd Bergmann
2014-05-22 11:56 ` [PATCH v2 " Lee Jones
2014-05-22 11:58 ` Lee Jones
2014-05-22 11:24 ` [PATCH 10/10] mtd: st_spi_fsm: General tidy-up Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522115216.GV6679@lee--X1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox