public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC
@ 2014-05-20 10:50 Paul Bolle
  2014-05-22 13:04 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-20 10:50 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: linux-mips, linux-kernel

A check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC was added in v2.6.29,
but without the related Kconfig symbol. Remove this check.

Also remove the test for an "ecc_verbose" kernel parameter. It is
undocumented and has no effect anyway.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.

Note that __cvmx_interrupt_ecc_report_single_bit_errors doesn't exist.

 arch/mips/cavium-octeon/setup.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index 331b837cec57..953ca85f84fa 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -779,12 +779,6 @@ void __init prom_init(void)
 				MAX_MEMORY = 32ull << 30;
 			if (*p == '@')
 				RESERVE_LOW_MEM = memparse(p + 1, &p);
-		} else if (strcmp(arg, "ecc_verbose") == 0) {
-#ifdef CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC
-			__cvmx_interrupt_ecc_report_single_bit_errors = 1;
-			pr_notice("Reporting of single bit ECC errors is "
-				  "turned on\n");
-#endif
 #ifdef CONFIG_KEXEC
 		} else if (strncmp(arg, "crashkernel=", 12) == 0) {
 			crashk_size = memparse(arg+12, &p);
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC
  2014-05-20 10:50 [PATCH] MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC Paul Bolle
@ 2014-05-22 13:04 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2014-05-22 13:04 UTC (permalink / raw)
  To: Paul Bolle; +Cc: linux-mips, linux-kernel

On Tue, May 20, 2014 at 12:50:55PM +0200, Paul Bolle wrote:

> A check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC was added in v2.6.29,
> but without the related Kconfig symbol. Remove this check.
> 
> Also remove the test for an "ecc_verbose" kernel parameter. It is
> undocumented and has no effect anyway.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
> 
> Note that __cvmx_interrupt_ecc_report_single_bit_errors doesn't exist.

I tried to chase the history of this but as far as I was able to find,
this is unused since I initially merged Octeon support; beyond that
I wasn't able to find any history.

So queued for 3.16.

Thanks!

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-22 13:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20 10:50 [PATCH] MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC Paul Bolle
2014-05-22 13:04 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox