From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM1480: remove checks for CONFIG_SIBYTE_BCM1480_PROF
Date: Thu, 22 May 2014 15:36:35 +0200 [thread overview]
Message-ID: <20140522133635.GE10287@linux-mips.org> (raw)
In-Reply-To: <1400750659.16832.24.camel@x220>
On Thu, May 22, 2014 at 11:24:19AM +0200, Paul Bolle wrote:
> There are two checks for CONFIG_SIBYTE_BCM1480_PROF in the tree since
> v2.6.15. The related Kconfig symbol has never been added to the tree. So
> these checks have always evaluated to false. Besides, one of these
> checks guards a call of sbprof_cpu_intr(). But that function is not
> defined. Remove all this.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> Until v2.6.23 there also were checks for CONFIG_SIBYTE_SB1250_PROF in
> the tree. There also was a Kconfig symbol SIBYTE_SB1250_PROF so it was
> possible to make these checks evaluate to true. But, since one of these
> checks also guarded a call of sbprof_cpu_intr(), that should have made
> the build fail with an error.
The Sibyte profiling was far inferior to later solutions such as oprofile
or perf and non-standard anyway. So let's kill what's left over.
Ralf
prev parent reply other threads:[~2014-05-22 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:24 [PATCH] MIPS: BCM1480: remove checks for CONFIG_SIBYTE_BCM1480_PROF Paul Bolle
2014-05-22 13:36 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522133635.GE10287@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox