From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbaEVSvM (ORCPT ); Thu, 22 May 2014 14:51:12 -0400 Received: from smtp.outflux.net ([198.145.64.163]:43120 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbaEVSvL (ORCPT ); Thu, 22 May 2014 14:51:11 -0400 Date: Thu, 22 May 2014 11:51:04 -0700 From: Kees Cook To: linux-kernel@vger.kernel.org Cc: "Paul E. McKenney" , Josh Triplett Subject: [PATCH] rcutorture: avoid format string leak to thead name Message-ID: <20140522185104.GA8674@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the rcutorture thread creation interface does not include format string arguments, make sure the name can never be accidentally processed as a format string. Signed-off-by: Kees Cook --- kernel/torture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/torture.c b/kernel/torture.c index acc9afc2f26e..9dad2ffaf995 100644 --- a/kernel/torture.c +++ b/kernel/torture.c @@ -694,7 +694,7 @@ int _torture_create_kthread(int (*fn)(void *arg), void *arg, char *s, char *m, int ret = 0; VERBOSE_TOROUT_STRING(m); - *tp = kthread_run(fn, arg, s); + *tp = kthread_run(fn, arg, "%s", s); if (IS_ERR(*tp)) { ret = PTR_ERR(*tp); VERBOSE_TOROUT_ERRSTRING(f); -- 1.7.9.5 -- Kees Cook Chrome OS Security