From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jesper Nilsson <jespern@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>
Subject: Re: [PATCH 2/4] cris: Update comments for generic idle conversion
Date: Fri, 23 May 2014 11:25:01 +0200 [thread overview]
Message-ID: <20140523092501.GI9198@axis.com> (raw)
In-Reply-To: <1400835265-21956-3-git-send-email-geert+renesas@glider.be>
On Fri, May 23, 2014 at 10:54:23AM +0200, Geert Uytterhoeven wrote:
> As of commit 8dc7c5ecd8d0f739728d844ee794c4fae169f9c2 ("cris: Use generic
> idle loop"), cris no longer provides cpu_idle().
>
> - On cris-v10, etrax_gpio_wake_up_check() is called from
> default_idle() instead of cpu_idle(),
> - On cris-v32, etrax_gpio_wake_up_check() is not called from
> default_idle(), so remove this (copy-and-paste?) part.
Yes, the comment for ETRAX FS (mach-fs) is definitely copy-pasted.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2014-05-23 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 8:54 [PATCH 0/4] cpuidle: Remove remaining cpu_idle() references Geert Uytterhoeven
2014-05-23 8:54 ` [PATCH 1/4] idle: Remove cpu_idle() forward declarations Geert Uytterhoeven
2014-05-23 8:54 ` [PATCH 2/4] cris: Update comments for generic idle conversion Geert Uytterhoeven
2014-05-23 9:25 ` Jesper Nilsson [this message]
2014-05-23 8:54 ` [PATCH 3/4] powerpc: " Geert Uytterhoeven
2014-05-23 8:54 ` [PATCH 4/4] tile: " Geert Uytterhoeven
2014-05-23 17:32 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523092501.GI9198@axis.com \
--to=jesper.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=geert+renesas@glider.be \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox