From: Lee Jones <lee.jones@linaro.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG
Date: Fri, 23 May 2014 11:10:56 +0100 [thread overview]
Message-ID: <20140523101056.GR19747@lee--X1> (raw)
In-Reply-To: <1400792131.16407.33.camel@x220>
> A check for CONFIG_DBX500_PRCMU_DEBUG was added in v3.6. But there's no
> Kconfig symbol DBX500_PRCMU_DEBUG. So remove this check.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested. Note that db8500_prcmu_debug_dump() is nowhere to be found in
> the tree.
>
> This check has been in the tree for less than two years. Am I being
> impatient here?
>
> drivers/mfd/db8500-prcmu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index 7694e0700d34..c248bde367ab 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2303,9 +2303,6 @@ int prcmu_ac_wake_req(void)
>
> if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
> msecs_to_jiffies(5000))) {
> -#if defined(CONFIG_DBX500_PRCMU_DEBUG)
> - db8500_prcmu_debug_dump(__func__, true, true);
> -#endif
> pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
> __func__);
> ret = -EFAULT;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-05-23 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 20:55 [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG Paul Bolle
2014-05-23 10:10 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523101056.GR19747@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox