From: Mark Brown <broonie@kernel.org>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
lkml <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
Doug Anderson <dianders@chromium.org>,
"jerry.wong" <jerry.wong@maximintegrated.com>
Subject: Re: [PATCH 1/2] ASoC: max98090: Add master clock handling
Date: Fri, 23 May 2014 12:14:46 +0100 [thread overview]
Message-ID: <20140523111446.GA12304@sirena.org.uk> (raw)
In-Reply-To: <CAHbNUh2QHv8n7Y19qfO7BagX5AWe0i17MjDvr7yOpHf6YNGW4A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Fri, May 23, 2014 at 11:05:17AM +0530, Tushar Behera wrote:
> I tested with moving clk_enable/clk_disable calls to set_bias_level():
> SND_SOC_BIAS_PREPARE. That works well for me. Does it look okay?
> + if (!IS_ERR(max98090->mclk)) {
> + if (codec->dapm.bias_level == SND_SOC_BIAS_ON)
> + clk_disable(max98090->mclk);
> + else
> + clk_enable(max98090->mclk);
> + }
> break;
Should be clk_prepare_enable() and similarly for the disable and you
should check the error codes but yes, that looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-23 11:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:17 [PATCH 0/2] ASoC: max98090/max98095: Add master clock handing Tushar Behera
2014-05-22 9:17 ` [PATCH 1/2] ASoC: max98090: Add master clock handling Tushar Behera
2014-05-22 10:30 ` Mark Brown
2014-05-23 5:35 ` Tushar Behera
2014-05-23 11:14 ` Mark Brown [this message]
2014-05-23 11:36 ` Tushar Behera
2014-05-23 11:41 ` Mark Brown
2014-05-23 12:02 ` Tushar Behera
2014-05-22 15:51 ` Stephen Warren
2014-05-22 17:34 ` Mark Brown
2014-05-22 17:50 ` Stephen Warren
2014-05-22 18:19 ` Mark Brown
2014-05-22 22:24 ` Stephen Warren
2014-05-22 23:36 ` Mark Brown
2014-05-22 9:17 ` [PATCH 2/2] ASoC: max98095: " Tushar Behera
2014-05-22 10:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523111446.GA12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jerry.wong@maximintegrated.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox