From: Greg KH <gregkh@linuxfoundation.org>
To: David Matlack <matlackdavid@gmail.com>
Cc: devel@driverdev.osuosl.org, charrer@alacritech.com,
linux-kernel@vger.kernel.org, liodot@gmail.com
Subject: Re: [PATCH 2/2] staging: slicoss: handle errors from slic_config_get
Date: Fri, 23 May 2014 20:16:25 +0900 [thread overview]
Message-ID: <20140523111625.GA4092@kroah.com> (raw)
In-Reply-To: <1400819925-19390-3-git-send-email-matlackdavid@gmail.com>
On Thu, May 22, 2014 at 09:38:45PM -0700, David Matlack wrote:
> slic_config_get() can fail. Change the return type from void to
> int and handle the error in slic_card_init(). So now, instead of
> silently failing (and then timing out waiting for the config data),
> the driver will fail loudly at request time.
>
> Signed-off-by: David Matlack <matlackdavid@gmail.com>
> ---
> drivers/staging/slicoss/slicoss.c | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
It looks like I had already applied patch 1/2 here, but not this one,
odd.
Anyway, I've applied this, and should be synced up with you now. If I
have missed applying anything, please resend.
thanks,
greg k-h
prev parent reply other threads:[~2014-05-23 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 4:38 [PATCH 0/2] fix two bugs in slic_card_init David Matlack
2014-05-23 4:38 ` [PATCH 1/2] staging: slicoss: fix dma memory leak David Matlack
2014-05-23 4:38 ` [PATCH 2/2] staging: slicoss: handle errors from slic_config_get David Matlack
2014-05-23 11:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523111625.GA4092@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=matlackdavid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox