From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dominique van den Broeck <domdevlin@free.fr>
Cc: Willy Tarreau <willy@meta-x.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: panel: (coding style) Multiple assignments
Date: Fri, 23 May 2014 20:33:46 +0900 [thread overview]
Message-ID: <20140523113346.GA10649@kroah.com> (raw)
In-Reply-To: <1400674201-9560-3-git-send-email-domdevlin@free.fr>
On Wed, May 21, 2014 at 02:10:01PM +0200, Dominique van den Broeck wrote:
> Style-only modifications to comply with checkpatch.pl --strict --file.
> . Breaks down compound assignments.
>
> Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
> ---
> Apply on linux-next tree, above:
> commit 4151fa6adc65da14673ece623bbb2acc6936f8be
> "Add linux-next specific files for 20140516"
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 1ac5e25..8d15b04 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -664,8 +664,8 @@ static void pin_to_bits(int pin, unsigned char *d_val, unsigned char *c_val)
> {
> int d_bit, c_bit, inv;
>
> - d_val[0] = c_val[0] = d_val[1] = c_val[1] = 0;
> - d_val[2] = c_val[2] = 0xFF;
> + d_val[0] = 0 ; c_val[0] = 0 ; d_val[1] = 0 ; c_val[1] = 0;
> + d_val[2] = 0xFF; c_val[2] = 0xFF;
Honestly, that's harder to read now, so I'll just leave this all alone
and not apply this patch.
Becides, you got the ; wrong...
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-23 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:09 [PATCH 1/3] staging: panel: (coding style) Matching braces Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 2/3] staging: panel: (coding style) Line alignments and malloc sizeof Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 3/3] staging: panel: (coding style) Multiple assignments Dominique van den Broeck
2014-05-23 11:33 ` Greg Kroah-Hartman [this message]
2014-05-23 23:35 ` [PATCH v2 " Dominique van den Broeck
2014-05-26 14:28 ` [PATCH 1/3] staging: panel: (coding style) Matching braces Willy Tarreau
2014-05-26 14:45 ` Dominique van den Broeck
2014-05-26 15:05 ` Willy Tarreau
2014-05-26 17:28 ` Joe Perches
2014-05-26 17:49 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523113346.GA10649@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=domdevlin@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox