* [PATCH] staging: wlags49_h2: fix sparse warning "should it be static"
@ 2014-05-07 16:31 Luis Ortega
2014-05-23 16:53 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Luis Ortega @ 2014-05-07 16:31 UTC (permalink / raw)
To: pe1dnn
Cc: gregkh, monamagarwal123, josh, archanakumari959, paulmck, devel,
linux-kernel, Luis Ortega
Fixes the following warning:
drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?
Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
---
drivers/staging/wlags49_h2/sta_h2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlags49_h2/sta_h2.c b/drivers/staging/wlags49_h2/sta_h2.c
index 0ba8def..2838faa 100644
--- a/drivers/staging/wlags49_h2/sta_h2.c
+++ b/drivers/staging/wlags49_h2/sta_h2.c
@@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
{ 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } } /* endsentinel */
};
-memimage fw_image = {
+static memimage fw_image = {
"FUPU7D37dhfwci\001C", /* signature, <format number>, C/Bin type */
(CFG_PROG_STRCT *) fw_image_code,
0x000F368E,
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wlags49_h2: fix sparse warning "should it be static"
2014-05-07 16:31 [PATCH] staging: wlags49_h2: fix sparse warning "should it be static" Luis Ortega
@ 2014-05-23 16:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-05-23 16:53 UTC (permalink / raw)
To: Luis Ortega
Cc: pe1dnn, devel, josh, linux-kernel, monamagarwal123, paulmck,
archanakumari959
On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote:
> Fixes the following warning:
> drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?
>
> Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
> ---
> drivers/staging/wlags49_h2/sta_h2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlags49_h2/sta_h2.c b/drivers/staging/wlags49_h2/sta_h2.c
> index 0ba8def..2838faa 100644
> --- a/drivers/staging/wlags49_h2/sta_h2.c
> +++ b/drivers/staging/wlags49_h2/sta_h2.c
> @@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
> { 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } } /* endsentinel */
> };
>
> -memimage fw_image = {
> +static memimage fw_image = {
> "FUPU7D37dhfwci\001C", /* signature, <format number>, C/Bin type */
> (CFG_PROG_STRCT *) fw_image_code,
> 0x000F368E,
ALWAYS test build your patches. This patch breaks the build :(
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-23 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 16:31 [PATCH] staging: wlags49_h2: fix sparse warning "should it be static" Luis Ortega
2014-05-23 16:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox