From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Bolle <pebolle@tiscali.nl>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB
Date: Fri, 23 May 2014 23:37:01 +0200 [thread overview]
Message-ID: <20140523213701.GD23153@alberich> (raw)
In-Reply-To: <20140522132645.GC10287@linux-mips.org>
On Thu, May 22, 2014 at 03:26:45PM +0200, Ralf Baechle wrote:
> On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote:
>
> > Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the
> > Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these
> > checks.
> >
> > Also remove the last reference to octeon_get_boot_debug_flag(). There is
> > no definition of that function anyway.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>
> Queued for 3.16. Thanks Paul & Andreas!
>
> > A follow up might be to remove plat_smp_ops.cpus_done. All these
> > callbacks are now (basically) nops.
>
> I'll think about it. The hook is no useful if unused then again now and
> then ordering issues in SMP startup of secondary CPUs are showing up and
> it may be useful to solve those. Maybe something like
>
> void __init smp_cpus_done(unsigned int max_cpus)
> {
> - mp_ops->cpus_done();
> + if (cpus_done)
> + mp_ops->cpus_done();
> }
>
> which would make a NULL cpus_done function pointer safe and allow empty definitions
> to be removed.
I'd prefer this solution over complete removal of the hook.
Andreas
next prev parent reply other threads:[~2014-05-23 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 16:16 [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB Paul Bolle
2014-05-21 20:27 ` Andreas Herrmann
2014-05-21 20:44 ` Paul Bolle
2014-05-22 13:26 ` Ralf Baechle
2014-05-23 21:37 ` Andreas Herrmann [this message]
2014-05-27 9:05 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523213701.GD23153@alberich \
--to=herrmann.der.user@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox