* [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
@ 2014-05-23 21:39 Chaitanya Hazarey
2014-05-23 22:25 ` Greg KH
2014-05-23 22:54 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Chaitanya Hazarey @ 2014-05-23 21:39 UTC (permalink / raw)
To: gregkh, christoph.kohl, michael.hoefler, rupert; +Cc: linux-kernel, devel, c
Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:
drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations
drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey <c@24.io>
---
drivers/staging/silicom/bypasslib/bypass.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c
index a58251f..8e714a8 100644
--- a/drivers/staging/silicom/bypasslib/bypass.c
+++ b/drivers/staging/silicom/bypasslib/bypass.c
@@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
static int is_dev_sd(int if_index)
{
int ret = 0;
+
SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
return ret >= 0 ? 1 : 0;
}
@@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
static int is_bypass(int if_index)
{
int ret = 0;
+
SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
if (ret < 0)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
2014-05-23 21:39 [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings Chaitanya Hazarey
@ 2014-05-23 22:25 ` Greg KH
2014-05-23 22:54 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-05-23 22:25 UTC (permalink / raw)
To: Chaitanya Hazarey
Cc: christoph.kohl, michael.hoefler, rupert, devel, linux-kernel
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:
>
> drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations
> drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations
>
> Signed-off-by: Chaitanya Hazarey <c@24.io>
> ---
> drivers/staging/silicom/bypasslib/bypass.c | 2 ++
> 1 file changed, 2 insertions(+)
This patch doesn't apply cleanly. Can you please refresh it against my
staging-next branch of staging.git on git.kernel.org and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
2014-05-23 21:39 [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings Chaitanya Hazarey
2014-05-23 22:25 ` Greg KH
@ 2014-05-23 22:54 ` Dan Carpenter
2014-05-24 5:31 ` Chaitanya Hazarey
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-23 22:54 UTC (permalink / raw)
To: Chaitanya Hazarey
Cc: gregkh, christoph.kohl, michael.hoefler, rupert, devel,
linux-kernel
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:
>
> drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations
> drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations
>
> Signed-off-by: Chaitanya Hazarey <c@24.io>
Still doesn't apply, I'm afraid.
> ---
> drivers/staging/silicom/bypasslib/bypass.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c
> index a58251f..8e714a8 100644
> --- a/drivers/staging/silicom/bypasslib/bypass.c
> +++ b/drivers/staging/silicom/bypasslib/bypass.c
> @@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
> static int is_dev_sd(int if_index)
> {
> int ret = 0;
> +
> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
> return ret >= 0 ? 1 : 0;
> }
> @@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
> static int is_bypass(int if_index)
> {
> int ret = 0;
> +
> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
> if (ret < 0)
There was supposed to be a blank line between the call to
SET_BPLIB_INT_FN() and the return check and it got deleted for some
reason.
regards,
dan carpetner
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings
2014-05-23 22:54 ` Dan Carpenter
@ 2014-05-24 5:31 ` Chaitanya Hazarey
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Hazarey @ 2014-05-24 5:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, christoph.kohl, michael.hoefler, rupert,
devel, linux-kernel
Hey Dan,
Thanks for your patience, I have resubmitted via a new email. Hope that works.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 3:54 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:
>>
>> drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations
>> drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations
>>
>> Signed-off-by: Chaitanya Hazarey <c@24.io>
>
> Still doesn't apply, I'm afraid.
>
>> ---
>> drivers/staging/silicom/bypasslib/bypass.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/silicom/bypasslib/bypass.c b/drivers/staging/silicom/bypasslib/bypass.c
>> index a58251f..8e714a8 100644
>> --- a/drivers/staging/silicom/bypasslib/bypass.c
>> +++ b/drivers/staging/silicom/bypasslib/bypass.c
>> @@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
>> static int is_dev_sd(int if_index)
>> {
>> int ret = 0;
>> +
>> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
>> return ret >= 0 ? 1 : 0;
>> }
>> @@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
>> static int is_bypass(int if_index)
>> {
>> int ret = 0;
>> +
>> SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
>> if (ret < 0)
>
> There was supposed to be a blank line between the call to
> SET_BPLIB_INT_FN() and the return check and it got deleted for some
> reason.
>
> regards,
> dan carpetner
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-24 5:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-23 21:39 [PATCH] Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings Chaitanya Hazarey
2014-05-23 22:25 ` Greg KH
2014-05-23 22:54 ` Dan Carpenter
2014-05-24 5:31 ` Chaitanya Hazarey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox