From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751352AbaEXT7K (ORCPT ); Sat, 24 May 2014 15:59:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53281 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbaEXT7J (ORCPT ); Sat, 24 May 2014 15:59:09 -0400 Date: Sat, 24 May 2014 12:59:07 -0700 From: Greg Kroah-Hartman To: Johan Hovold Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Peter Hurley , One Thousand Gnomes , Xiao Jin , david.a.cohen@linux.intel.com, yanmin.zhang@intel.com, Oliver Neukum Subject: Re: [PATCH] USB: cdc-acm: fix broken runtime suspend Message-ID: <20140524195907.GB922@kroah.com> References: <20140411093715.GA17522@localhost> <1397505492-10018-1-git-send-email-jhovold@gmail.com> <20140524144242.GC10266@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140524144242.GC10266@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 24, 2014 at 04:42:42PM +0200, Johan Hovold wrote: > On Mon, Apr 14, 2014 at 09:58:12PM +0200, Johan Hovold wrote: > > The current ACM runtime-suspend implementation is broken in several > > ways: > > > > Firstly, it buffers only the first write request being made while > > suspended -- any further writes are silently dropped. > > > > Secondly, writes being dropped also leak write urbs, which are never > > reclaimed (until the device is unbound). > > > > Thirdly, even the single buffered write is not cleared at shutdown > > (which may happen before the device is resumed), something which can > > lead to another urb leak as well as a PM usage-counter leak. > > > > Fix this by implementing a delayed-write queue using urb anchors and > > making sure to discard the queue properly at shutdown. > > > > Reported-by: Xiao Jin > > Signed-off-by: Johan Hovold > > Greg, > > I understand yoǘ're on your way home from Japan and are getting ready to > work through the 3.16 patch queue. > > Could you please discard this one for now? I've found a couple of more > PM related problems and I'll submit a slight update of this one as part > of a larger series of fixes instead. I think it's already in my tree, right? I don't see it in my to-apply queue. Can you send me the git id to revert, or just a patch that reverts it? thanks, greg k-h