From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Emil Goode <emilgoode@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Shawn Guo" <shawn.guo@freescale.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Russell King" <linux@arm.linux.org.uk>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera
Date: Sat, 24 May 2014 13:05:00 -0700 [thread overview]
Message-ID: <20140524200500.GB1023@kroah.com> (raw)
In-Reply-To: <20140524152200.GA4666@lianli>
On Sat, May 24, 2014 at 05:22:00PM +0200, Emil Goode wrote:
> Hello Uwe and Greg,
>
> > You'd do a better deed if you picked up
> > http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995
>
> Since there is nothing wrong with the last version of the patch in
> the above thread, I feel strange about picking it up and just splitting
> it into two patches. However it would be good to have it applied.
>
> I think the reason why the author didn't resend is that the object file
> and data structure layout information in the changelog depend on the
> changes to both .name and .dma_mask and by splitting the patch this
> information would not apply to any one of the resulting two patches.
>
> Perhaps keeping this information in the changelog is a good reason for
> applying the patch as it is?
If you read the thread, I explained why I didn't want to take the patch
as-is. Please feel free to break it up as asked for and I'll be glad to
consider it then.
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-24 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 17:51 [PATCH] ARM: imx: introduce function imx_free_mx3_camera Emil Goode
2014-05-22 18:10 ` Uwe Kleine-König
2014-05-22 18:58 ` Emil Goode
2014-05-23 6:50 ` Philippe Rétornaz
2014-05-24 15:22 ` Emil Goode
2014-05-24 20:05 ` Greg Kroah-Hartman [this message]
2014-05-24 21:17 ` Uwe Kleine-König
2014-05-22 20:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140524200500.GB1023@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=shc_work@mail.ru \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox