From: Josh Triplett <josh@joshtriplett.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/4] lib/debugobjects.c: code clean-up
Date: Sat, 24 May 2014 15:00:09 -0700 [thread overview]
Message-ID: <20140524220009.GD24038@thin> (raw)
In-Reply-To: <1400936886-25055-1-git-send-email-fabf@skynet.be>
On Sat, May 24, 2014 at 03:08:06PM +0200, Fabian Frederick wrote:
> Fix some checkpatch warnings.
>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Some of these make sense, one of them does not. Comments below.
Also, please explicitly note the checkpatch warnings you fixed, not just
"Fix some checkpatch warnings.".
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
[...]
> @@ -415,7 +415,8 @@ int debug_object_activate(void *addr, struct debug_obj_descr *descr)
> debug_print_object(obj, "activate");
> state = obj->state;
> raw_spin_unlock_irqrestore(&db->lock, flags);
> - ret = debug_object_fixup(descr->fixup_activate, addr, state);
> + ret = debug_object_fixup(descr->fixup_activate,
> + addr, state);
This does not seem like a worthwhile improvement. Please don't blindly
listen to checkpatch, especially regarding line lengths.
- Josh Triplett
next prev parent reply other threads:[~2014-05-24 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 13:08 [PATCH 4/4] lib/debugobjects.c: code clean-up Fabian Frederick
2014-05-24 22:00 ` Josh Triplett [this message]
2014-05-25 3:17 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140524220009.GD24038@thin \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox