From: Josh Triplett <josh@joshtriplett.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] lib/debugobjects.c: convert printk to pr_foo()
Date: Sat, 24 May 2014 20:40:43 -0700 [thread overview]
Message-ID: <20140525034043.GA26647@thin> (raw)
In-Reply-To: <20140525051836.116fe09126f16de8b3955d27@skynet.be>
On Sun, May 25, 2014 at 05:18:36AM +0200, Fabian Frederick wrote:
> On Sat, 24 May 2014 14:53:22 -0700
> Josh Triplett <josh@joshtriplett.org> wrote:
>
> > On Sat, May 24, 2014 at 03:06:08PM +0200, Fabian Frederick wrote:
> > > Convert all except KERN_DEBUG
> >
> > Why not KERN_DEBUG?
> printk(KERN_DEBUG can't be converted to pr_debug the same way as other printk.
True, but I don't see any obvious reason why that prevents you from
converting them. More importantly, though, you should explain for the
benefit of the changelog.
- Josh Triplett
next prev parent reply other threads:[~2014-05-25 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 13:06 [PATCH 1/4] lib/debugobjects.c: convert printk to pr_foo() Fabian Frederick
2014-05-24 21:53 ` Josh Triplett
2014-05-25 3:18 ` Fabian Frederick
2014-05-25 3:40 ` Josh Triplett [this message]
2014-05-27 14:25 ` Fabian Frederick
2014-05-28 4:10 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140525034043.GA26647@thin \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).