From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbaEYSI5 (ORCPT ); Sun, 25 May 2014 14:08:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60693 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbaEYSI4 (ORCPT ); Sun, 25 May 2014 14:08:56 -0400 Date: Sun, 25 May 2014 11:08:55 -0700 From: Greg Kroah-Hartman To: Peter Senna Tschudin Cc: devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8 V2] drivers/staging: Remove useless return variables Message-ID: <20140525180855.GA30986@kroah.com> References: <1400929608-31128-1-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400929608-31128-1-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 24, 2014 at 01:06:48PM +0200, Peter Senna Tschudin wrote: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. > > Verified by compilation only. > > The coccinelle script that find and fixes this issue is: > // > @@ > type T; > constant C; > identifier ret; > @@ > - T ret = C; > ... when != ret > when strict > return > - ret > + C > ; > // > > Signed-off-by: Peter Senna Tschudin > > --- > Changes from V1: > - Updated semantic patch > - Refreshed for next-20140523 Can you refresh again? It still doesn't apply :( thanks, greg k-h