public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Masaru Nomura <massa.nomura@gmail.com>
Cc: andreas.dilger@intel.com, Oleg Drokin <green@linuxhacker.ru>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c
Date: Sun, 25 May 2014 16:30:39 -0700	[thread overview]
Message-ID: <20140525233039.GA28206@kroah.com> (raw)
In-Reply-To: <CAAvxhqCX=PmSerzQZKdpUQCiehhEeGDs1RN1woYL_oJ++EkzQg@mail.gmail.com>

On Sun, May 25, 2014 at 11:50:03PM +0100, Masaru Nomura wrote:
> 
> 
> 
> 2014-05-25 23:37 GMT+01:00 Greg KH <gregkh@linuxfoundation.org>:
> 
>     On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote:
>     > Remove prohibited space between function name and
>     > open parenthesis to meet kernel coding style.
>     > Also fix indenting due to changes to keep readability.
>     >
>     > -since v2:
>     > None. This is the resend of v2 as v2 failed to apply
> 
>     This should be below the --- line.
> 
> 
> 
> I'm sorry for that. Will fix it.
>  
> 
>     And it still doesn't apply :(
> 
>     What branch did you make it against?
> 
> 
> 
> I'm using[1] which is your staging.git (is it correct?) and downloaded it
> today.  So, there should not be a patch failure... :(

What _branch_ of that git tree did you make it against?

And please don't send html email, the mailing lists reject it.

thanks,

greg k-h

  parent reply	other threads:[~2014-05-25 23:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-25 22:24 [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c Masaru Nomura
2014-05-25 22:37 ` Greg KH
     [not found]   ` <CAAvxhqCX=PmSerzQZKdpUQCiehhEeGDs1RN1woYL_oJ++EkzQg@mail.gmail.com>
2014-05-25 23:30     ` Greg KH [this message]
2014-05-25 23:57       ` Masaru Nomura
2014-05-26  0:26         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140525233039.GA28206@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=green@linuxhacker.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=massa.nomura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox