From: Greg KH <gregkh@linuxfoundation.org>
To: Chaitanya Hazarey <c@24.io>
Cc: chad@dahc.us, michael.banken@mathe.stud.uni-erlangen.de,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines
Date: Sun, 25 May 2014 17:51:51 -0700 [thread overview]
Message-ID: <20140526005151.GB3129@kroah.com> (raw)
In-Reply-To: <1401064618-29405-1-git-send-email-c@24.io>
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl:
Always wrap your lines at 72 columns, like git asks you to when you type
in the commit message.
> WARNING: Missing a blank line after declarations
>
> The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this patch.
This doesn't belong as part of the changelog, right? Please resend and
put it below the --- line, if you want to.
Can you redo this with the changelog fixed up please?
thanks,
greg k-h
next prev parent reply other threads:[~2014-05-26 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 0:36 [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines Chaitanya Hazarey
2014-05-26 0:51 ` Greg KH [this message]
2014-05-26 4:57 ` Chaitanya Hazarey
-- strict thread matches above, loose matches on Subject: below --
2014-05-26 4:58 Chaitanya Hazarey
2014-05-26 5:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526005151.GB3129@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=c@24.io \
--cc=chad@dahc.us \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.banken@mathe.stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox