From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbaEZRvu (ORCPT ); Mon, 26 May 2014 13:51:50 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33798 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbaEZRvt (ORCPT ); Mon, 26 May 2014 13:51:49 -0400 Date: Mon, 26 May 2014 19:51:38 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Jiri Kosina , "H. Peter Anvin" , Linus Torvalds , Thomas Gleixner , Steven Rostedt , Andi Kleen , "linux-kernel@vger.kernel.org" , Ingo Molnar , "Luck, Tony" Subject: Re: [PATCH] x86, MCE: Flesh out when to panic comment Message-ID: <20140526175138.GB26531@pd.tnic> References: <537D1E8B.1010505@zytor.com> <20140521215411.GI25130@pd.tnic> <537D21F2.8030702@zytor.com> <20140521221121.GL25130@pd.tnic> <537D2522.80702@zytor.com> <20140526101859.GD25732@pd.tnic> <20140526110634.GG25732@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 26, 2014 at 09:47:38AM -0700, Andy Lutomirski wrote: > It may be worth at least pointing out that mce_severity looks at > whether we faulted from kernel context. I missed that the first time > around because mce_severity doesn't take a pt_regs pointer. Right, but next time we talk about a different aspect which isn't commented on in the handler, we'd have to add to it again, until we've rewritten the whole function in pseudo code. I think simply pointing to the function which decides the fate of the machine based on the MCE severity is enough - people can then go and stare at it, albeit with some struggle. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --