Re: [PATCH 1/3] driver core/platform: don't leak memory allocated for dma_mask

Emil Goode
2014-05-26T19:39:46Z

Hello,

On Mon, May 26, 2014 at 10:30:46PM +0300, Dan Carpenter wrote:
> On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> > index 9e9227e..dd1fa07 100644
> > --- a/drivers/base/platform.c
> > +++ b/drivers/base/platform.c
> > @@ -166,6 +166,7 @@ EXPORT_SYMBOL_GPL(platform_add_devices);
> > struct platform_object {
> > struct platform_device pdev;
> > char name[1];
> > + u64 dma_mask;
> > };
>
> Heh. No this doesn't work as patch #1. You have to have name at the
> end of the struct.

Yes I missed that one, obviously the order is important here.

Best regards,

Emil Goode