From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 1/4] get_maintainer: use three argument open
Date: Mon, 26 May 2014 13:33:10 -0700 [thread overview]
Message-ID: <20140526203352.885433946@networkplumber.org> (raw)
In-Reply-To: 20140526203309.782169359@networkplumber.org
[-- Attachment #1: get_maintainer-perlcritic.patch --]
[-- Type: text/plain, Size: 528 bytes --]
Use 3 argument open to avoid any issues with parsing
and silence perlcritic.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/scripts/get_maintainer.pl 2014-05-26 12:47:35.039720690 -0700
+++ b/scripts/get_maintainer.pl 2014-05-26 13:27:52.000000000 -0700
@@ -426,7 +426,7 @@ foreach my $file (@ARGV) {
my $file_cnt = @files;
my $lastfile;
- open(my $patch, "< $file")
+ open(my $patch, '<', $file)
or die "$P: Can't open $file: $!\n";
# We can check arbitrary information before the patch
next prev parent reply other threads:[~2014-05-26 20:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 20:33 [PATCH 0/4] get_maintainer script cleanups Stephen Hemminger
2014-05-26 20:33 ` Stephen Hemminger [this message]
2014-05-26 20:33 ` [PATCH 2/4] get_maintainer: remove quoting on hash label Stephen Hemminger
2014-05-26 20:33 ` [PATCH 3/4] get_maintainer: use array for defining available version control Stephen Hemminger
2014-05-26 20:33 ` [PATCH 4/4] get_maintainer: use anonymous function instead of eval Stephen Hemminger
2014-05-27 1:00 ` [PATCH 0/4] get_maintainer script cleanups Joe Perches
2014-05-27 1:03 ` Joe Perches
2014-05-27 1:09 ` Stephen Hemminger
2014-05-27 1:22 ` [PATCH 5/4] get_maintainer: shut up perl critic Stephen Hemminger
2014-05-27 1:32 ` Joe Perches
2014-05-27 17:00 ` Stephen Hemminger
2014-05-27 1:06 ` [PATCH 0/4] get_maintainer script cleanups Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526203352.885433946@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox