From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752202AbaE0J5Z (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 May 2014 05:57:25 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:36443 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751686AbaE0J5W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 May 2014 05:57:22 -0400
Date: Tue, 27 May 2014 12:55:05 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Heesub Shin <heesub.shin@samsung.com>
Cc: devel@driverdev.osuosl.org, Sunghwan Yun <sunghwan.yun@samsung.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Daeseok Youn <daeseok.youn@gmail.com>, linux-kernel@vger.kernel.org,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        John Stultz <john.stultz@linaro.org>, Colin Cross <ccross@android.com>,
        Rebecca Schultz Zavin <rebecca@android.com>,
        Mitchel Humpherys <mitchelh@codeaurora.org>
Subject: Re: [PATCH 1/9] staging: ion: tidy up a bit
Message-ID: <20140527094609.GL15585@mwanda>
References: <1401098701-24049-1-git-send-email-heesub.shin@samsung.com>
 <20140526103612.GE15585@mwanda>
 <5383E32A.6040009@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5383E32A.6040009@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote:
> Hello Carpenter,
> 
> On 05/26/2014 07:36 PM, Dan Carpenter wrote:
> >On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> >>@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
> >>
> >>  		info->page = page;
> >>  		info->order = orders[i];
> >>-		INIT_LIST_HEAD(&info->list);
> >>  		return info;
> >>  	}
> >>  	kfree(info);
> >
> >Wait.  How does this code work without that INIT_LIST_HEAD()?  What am
> >I missing here...
> 
> No problem. As the object info is just a node, not a head, it is
> completely useless to initialize it as a list head.
> 

Oh, sorry, you are right.  My bad.

regards,
dan carpenter