From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <tom.leiming@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker
Date: Tue, 27 May 2014 20:53:01 +0200 [thread overview]
Message-ID: <20140527185301.GA8466@lst.de> (raw)
In-Reply-To: <5384DB97.70606@kernel.dk>
On Tue, May 27, 2014 at 12:38:15PM -0600, Jens Axboe wrote:
> On 2014-05-27 12:13, Christoph Hellwig wrote:
>> Here is my counter proposal that requeues via two lists and a work struct
>> in the request_queue. I've also tested it with scsi-mq.
>>
>
> I like this, moves the state out of the request. But how about we
> consolidate the two requeue requests lists, and just mark the request as
> needing head insertion instead? Just add a cmd_flags flag, REQ_REQUEUE_HEAD
> or something.
That should be doable, just didn't like introducing even more flags.
next prev parent reply other threads:[~2014-05-27 18:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:05 [PATCH] block: mq flush: fix race between IPI handler and mq flush worker Ming Lei
2014-05-19 15:18 ` Christoph Hellwig
2014-05-19 15:34 ` Ming Lei
2014-05-20 3:20 ` Ming Lei
2014-05-20 15:23 ` Christoph Hellwig
2014-05-21 5:16 ` Ming Lei
2014-05-21 5:36 ` Christoph Hellwig
2014-05-21 6:48 ` Ming Lei
2014-05-27 18:13 ` Christoph Hellwig
2014-05-27 18:38 ` Jens Axboe
2014-05-27 18:53 ` Christoph Hellwig [this message]
2014-05-27 18:54 ` Jens Axboe
2014-05-27 19:15 ` Christoph Hellwig
2014-05-27 19:17 ` Jens Axboe
2014-05-27 19:21 ` Christoph Hellwig
2014-05-27 19:35 ` Jens Axboe
2014-05-28 1:34 ` Ming Lei
2014-05-28 2:26 ` Jens Axboe
2014-05-28 2:31 ` Jens Axboe
2014-05-28 5:22 ` Christoph Hellwig
2014-05-28 14:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527185301.GA8466@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).