From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chaitanya Hazarey <c@24.io>
Cc: gregkh@linuxfoundation.org, andrea.merello@gmail.com,
linville@tuxdriver.com, burzalodowa@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings
Date: Tue, 27 May 2014 23:39:56 +0300 [thread overview]
Message-ID: <20140527203956.GO15585@mwanda> (raw)
In-Reply-To: <1401221390-10655-1-git-send-email-c@24.io>
On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
> Fixed the following:
>
> ERROR: do not use C99 // comments
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ';' (ctx:VxV)
> ERROR: space required before the open brace '{'
> ERROR: spaces required around that '=' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: space required after that close brace '}'
> ERROR: spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
>
All of these patches have the same subject. And also they aren't
broken up in the correct way. Basically for this kind of thing we want
to see one kind of cleanup per patch.
[patch 1/6] Staging: rtl8192u: add missing spaces
[patch 2/6] Staging: rtl8192u: delete commented out code
[patch 3/6] Staging: rtl8192u: clean up c99 comments
[patch 4/6] Staging: rtl8192u: reformat long lines
...
Etc.
Sorry for asking people to redo these again...
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-27 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 20:09 [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings Chaitanya Hazarey
2014-05-27 20:09 ` [PATCH 2/6] " Chaitanya Hazarey
2014-05-27 20:09 ` [PATCH 3/6] " Chaitanya Hazarey
2014-05-27 20:09 ` [PATCH 4/6] " Chaitanya Hazarey
2014-05-27 20:09 ` [PATCH 5/6] " Chaitanya Hazarey
2014-05-27 20:09 ` [PATCH 6/6] " Chaitanya Hazarey
2014-05-27 20:39 ` Dan Carpenter [this message]
2014-05-27 21:17 ` [PATCH 1/6] " Chaitanya Hazarey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527203956.GO15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrea.merello@gmail.com \
--cc=burzalodowa@gmail.com \
--cc=c@24.io \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).