From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navin.patidar@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw_type()
Date: Tue, 27 May 2014 23:43:52 +0300 [thread overview]
Message-ID: <20140527204352.GP15585@mwanda> (raw)
In-Reply-To: <1401204955-4093-6-git-send-email-navin.patidar@gmail.com>
These would have been easier to review if this patch were folded in with
the previous two patches. What I look for in these patches is, "Will
the compile break if you get it wrong?"
For "[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to
padapter->chip_type directly", you could get it wrong and the compile
wouldn't break so I have to go into the code and look at it.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-27 20:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 15:35 [PATCH 01/15] staging: rtl8188eu:Remove function rtw_set_tx_chksum_offload() navin patidar
2014-05-27 15:35 ` [PATCH 02/15] staging:rtl8188eu:Remove code specific to kernel version < 2.6.35 navin patidar
2014-05-27 15:35 ` [PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue() navin patidar
2014-05-27 19:02 ` Greg KH
2014-05-28 15:20 ` navin patidar
2014-05-27 15:35 ` [PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to padapter->chip_type directly navin patidar
2014-05-27 15:35 ` [PATCH 05/15] staging: rtl8188eu:Remove unused function chip_by_usb_id() navin patidar
2014-05-27 15:35 ` [PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw_type() navin patidar
2014-05-27 20:43 ` Dan Carpenter [this message]
2014-05-27 15:35 ` [PATCH 07/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_init() navin patidar
2014-05-27 15:35 ` [PATCH 08/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_deinit() navin patidar
2014-05-27 15:35 ` [PATCH 09/15] staging: rtl8188eu:Remove unused function rtw_handle_dualmac() navin patidar
2014-05-27 15:35 ` [PATCH 10/15] staging: rtl8188eu:Remove unused variable struct adapter *pbuddy_padapter navin patidar
2014-05-27 20:52 ` Dan Carpenter
2014-05-27 15:35 ` [PATCH 11/15] staging: rtl8188eu:Remove inline function rtw_netif_wake_queue() navin patidar
2014-05-27 15:35 ` [PATCH 12/15] staging: rtl8188eu:Remove inline function rtw_netif_start_queue() navin patidar
2014-05-27 15:35 ` [PATCH 13/15] staging: rtl8188eu:Remove inline function rtw_netif_stop_queue() navin patidar
2014-05-27 15:35 ` [PATCH 14/15] staging: rtl8188eu:Remove unused inline function res_to_status() navin patidar
2014-05-27 15:35 ` [PATCH 15/15] staging: rtl8188eu:Remove unused macros defined in osdep_service.h navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527204352.GP15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).