Re: [PATCH] Staging: speakup: don't die if accessing sysfs without synth

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/staging/speakup/synth.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index 0b3549b..172cf62 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -212,6 +212,9 @@ void synth_start(void)
>  
>  void spk_do_flush(void)
>  {
> +	if (!synth)
> +		return;
> +
>  	speakup_info.flushing = 1;
>  	synth_buffer_clear();
>  	if (synth->alive) {
> -- 
> 1.7.10.4
> 

-- 
Samuel
Now I know someone out there is going to claim, "Well then, UNIX is intuitive,
because you only need to learn 5000 commands, and then everything else follows
from that! Har har har!"
(Andy Bates in comp.os.linux.misc, on "intuitive interfaces", slightly
defending Macs.)