Re: [PATCH 0/2] Per-task wait_queue_t

Peter Zijlstra
2014-06-10T15:50:44Z

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On Tue, Jun 10, 2014 at 02:29:17PM +0200, Rasmus Villemoes wrote:
> This is an attempt to reduce the stack footprint of various functions
> (those using any of the wait_event_* macros), by removing the need to
> allocate a wait_queue_t on the stack and instead use a single instance
> embedded in task_struct. I'm not really sure where the best place to
> put it is; I just placed it next to other list bookkeeping fields.
>
> For now, there is a little unconditional debugging. This could later
> be removed or maybe be made dependent on some CONFIG_* variable. The
> idea of using ->flags is taken from Pavel [1] (I originally stored
> (void*)1 into ->private).
>
> Compiles, but not actually tested.
>

Doesn't look too bad, would be good to be tested and have some numbers
on the amount of stack saved etc..

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]