From: Christoph Hellwig <hch@infradead.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org, Sam Creasey <sammy@sammy.net>,
Russell King <linux@arm.linux.org.uk>,
Michael Schmitz <schmitz@debian.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 09/12] scsi/NCR5380: fix and standardize NDEBUG macros
Date: Wed, 28 May 2014 02:54:23 -0700 [thread overview]
Message-ID: <20140528095423.GI26617@infradead.org> (raw)
In-Reply-To: <20140318004215.292486266@telegraphics.com.au>
On Tue, Mar 18, 2014 at 11:42:21AM +1100, Finn Thain wrote:
> All three NCR5380 core driver implementations share the same NCR5380.h
> header file so they need to agree on certain macro definitions.
>
> The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and
> sun3_NCR5380 collides with the bit used by NDEBUG_LISTS.
>
> Moreover, NDEBUG_ABORT appears in NCR5380.c so it should be defined in
> NCR5380.h rather than in each of the many drivers using that core.
>
> An undefined NDEBUG_ABORT macro caused compiler errors and led to dodgy
> workarounds in the core driver that can now be removed.
> (See commits f566a576bca09de85bf477fc0ab2c8c96405b77b and
> 185a7a1cd79b9891e3c17abdb103ba1c98d6ca7a.)
>
> Move all of the NDEBUG_ABORT, NDEBUG_TAGS and NDEBUG_MERGING macro
> definitions into NCR5380.h where all the other NDEBUG macros live.
>
> Also, incorrect "#ifdef NDEBUG" becomes "#if NDEBUG" to fix the warning:
> drivers/scsi/mac_scsi.c: At top level:
> drivers/scsi/NCR5380.c:418: warning: 'NCR5380_print' defined but not used
> drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used
>
> The debugging code is now enabled when NDEBUG != 0.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-05-28 9:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 0:42 [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure Finn Thain
2014-03-18 0:42 ` [PATCH 01/12] scsi/NCR5380: remove unused BOARD_NORMAL and BOARD_NCR53C400 Finn Thain
2014-05-28 9:48 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 02/12] scsi/NCR5380: remove redundant HOSTS_C macro tests Finn Thain
2014-05-28 9:49 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 03/12] scsi/NCR5380: remove old CVS keywords Finn Thain
2014-05-28 9:49 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 04/12] scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print() Finn Thain
2014-05-28 9:49 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 05/12] scsi/NCR5380: fix build failures when debugging is enabled Finn Thain
2014-05-28 9:50 ` Christoph Hellwig
2014-05-28 12:09 ` Finn Thain
2014-05-28 12:13 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 06/12] scsi/NCR5380: fix dprintk macro usage and definition Finn Thain
2014-05-28 9:50 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 07/12] scsi/NCR5380: adopt NCR5380_dprint() and NCR5380_dprint_phase() Finn Thain
2014-05-28 9:51 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 08/12] scsi/NCR5380: adopt dprintk() Finn Thain
2014-05-28 9:52 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 09/12] scsi/NCR5380: fix and standardize NDEBUG macros Finn Thain
2014-05-28 9:54 ` Christoph Hellwig [this message]
2014-03-18 0:42 ` [PATCH 10/12] scsi/NCR5380: remove unused macro definitions Finn Thain
2014-05-28 9:54 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 11/12] scsi/NCR5380: reduce depth of sun3_scsi nested includes Finn Thain
2014-05-28 9:55 ` Christoph Hellwig
2014-03-18 0:42 ` [PATCH 12/12] scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.c Finn Thain
2014-05-28 9:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528095423.GI26617@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@parallels.com \
--cc=fthain@telegraphics.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sammy@sammy.net \
--cc=schmitz@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).