From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbaE1KlT (ORCPT ); Wed, 28 May 2014 06:41:19 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:55920 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbaE1KlR (ORCPT ); Wed, 28 May 2014 06:41:17 -0400 Date: Wed, 28 May 2014 03:41:14 -0700 From: Christoph Hellwig To: Paul Bolle Cc: Russell King , "James E.J. Bottomley" , linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acornscsi: remove linked command support Message-ID: <20140528104114.GE13542@infradead.org> References: <1400926433.31526.89.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400926433.31526.89.camel@x220> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > The acornscsi driver was added in v2.1.88. It has always #undef-ed > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > sure, it has also always triggered a preprocessor error if > CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, > it has never even been possible to set SCSI_ACORNSCSI_LINK through > kconfig, or its predecessors, in the first place. > > Let's remove the code involved. > > Signed-off-by: Paul Bolle Looks good, Reviewed-by: Christoph Hellwig And I have to disagree with James here, removing code that isn't even compiled always is an improvement, especially for an unmaintained driver.