* [patch 2/2] ALSA: fireworks: small leak on error path
@ 2014-05-28 16:42 Dan Carpenter
2014-05-28 21:57 ` [alsa-devel] " Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-05-28 16:42 UTC (permalink / raw)
To: Clemens Ladisch
Cc: Jaroslav Kysela, Takashi Iwai, Takashi Sakamoto, alsa-devel,
linux-kernel, kernel-janitors
There was a typo here so we return directly instead of freeing "hwinfo".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
index 8e856cc..996fdc4 100644
--- a/sound/firewire/fireworks/fireworks.c
+++ b/sound/firewire/fireworks/fireworks.c
@@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
/* Hardware metering. */
if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS ||
hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) {
- return -EIO;
+ err = -EIO;
goto end;
}
efw->phys_in = hwinfo->phys_in;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path
2014-05-28 16:42 [patch 2/2] ALSA: fireworks: small leak on error path Dan Carpenter
@ 2014-05-28 21:57 ` Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2014-05-28 21:57 UTC (permalink / raw)
To: Dan Carpenter, Clemens Ladisch
Cc: alsa-devel, Takashi Iwai, kernel-janitors, linux-kernel
(May 29 2014 01:42), Dan Carpenter wrote:
> There was a typo here so we return directly instead of freeing "hwinfo".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index 8e856cc..996fdc4 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
> /* Hardware metering. */
> if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS ||
> hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) {
> - return -EIO;
> + err = -EIO;
> goto end;
> }
> efw->phys_in = hwinfo->phys_in;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/2] ALSA: fireworks: small leak on error path
2014-05-28 16:42 [patch 2/2] ALSA: fireworks: small leak on error path Dan Carpenter
2014-05-28 21:57 ` [alsa-devel] " Takashi Sakamoto
@ 2014-05-29 13:57 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2014-05-29 13:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Clemens Ladisch, Jaroslav Kysela, Takashi Sakamoto, alsa-devel,
linux-kernel, kernel-janitors
At Wed, 28 May 2014 19:42:46 +0300,
Dan Carpenter wrote:
>
> There was a typo here so we return directly instead of freeing "hwinfo".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Takashi
>
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index 8e856cc..996fdc4 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
> /* Hardware metering. */
> if (hwinfo->phys_in_grp_count > HWINFO_MAX_CAPS_GROUPS ||
> hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) {
> - return -EIO;
> + err = -EIO;
> goto end;
> }
> efw->phys_in = hwinfo->phys_in;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-29 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28 16:42 [patch 2/2] ALSA: fireworks: small leak on error path Dan Carpenter
2014-05-28 21:57 ` [alsa-devel] " Takashi Sakamoto
2014-05-29 13:57 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox